search

Leofeng10 / pe

0 stars 0 forks source link

Students can have same name when they are in different class #4

Open Leofeng10 opened 2 years ago

Leofeng10 commented 2 years ago

I am able to have students with the same name as shown in the screenshot. From UG, the name should be unique, but if students are in different classes, I can edit them to have the same name. If this is intentionally, like a student can be in multiple classes, then only one student information panel for that student should be displayed after list all command rather than having many same student information panels for that student.

Screen Shot 2021-11-12 at 4.51.36 PM.png

nus-pe-bot commented 2 years ago

Team's Response

The rationale for changing bug type and severity level has been provided in #3330.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Same person in different class allowed

Screenshot 2021-11-12 at 4.55.24 PM.png Screenshot 2021-11-12 at 4.55.30 PM.png

According to UG, duplicate people are defined as having the same name. In the above two screenshots, the person "Alan Tan" (with the same name, phone, address) is added to both 4e2 and 3E2. This should not be possible as this app is catered towards primary and secondary school teachers, and students cannot be part of two classes at the same time.

Can be an issue for teachers who manage multiple classes.

[original: nus-cs2103-AY2122S1/pe-interim#3291] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thanks for the issue. We reject this bug because it is totally an expected and correct behaviour, and we have designed the feature to be like that. We don’t think it is mentioned anywhere in UG that duplicate students cannot exist in the TeachBook at the same time. Under the “add” command section in UG, we are explicitly saying that “The NAME is case and space sensitive and should not be already inside the class.” In fact, students with the same name can be added into different classes and they are not really duplicate. Such a design is also realistic because there can be students having the same name taught by the same teacher but in different classes. On a side note, we do not allow students with the same name in the same class simply because such a chance is very small, but it could cause unnecessary confusion to users if we allow this. As discussed above, we change the bug type to feature flaw from functionality bug because we think the current behaviour is as specified/expected. Lastly, as we don’t think this is a bug at all, we cannot choose a proper severity level.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]

:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]