Leofeng10 / pe

0 stars 0 forks source link

mark and unmark results #6

Open Leofeng10 opened 2 years ago

Leofeng10 commented 2 years ago

When a student is not present, and I use unmark command, the result displayed is the same as the student who is present. Ideally, there should be two different messages given to users. mark has the same issue Screen Shot 2021-11-12 at 5.04.48 PM.png

nus-pe-bot commented 2 years ago

Team's Response

Thanks for the issue. We reject the bug because we think it is a correct and expected behavior. Firstly, for mark command, users should be allowed to mark a present student again in order to update his/her attendance datetime to the current time (the datetime will be useful with the print command). Secondly, mark all and unmark all will also mark/unmark all the students, regardless of their current attendance status. Lastly, due to the previous two reasons, we allow users to unmark an absent student as well simply because this does not cause any inconvenience from users' point of view. On the contrary, preventing users from doing this can cause some inconsistency in the commands, which will cause confusion and make it harder for users to remember and use the command.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]