search

LeonAdato / xk6-output-statsd

k6 extension to output real-time test metrics using StatsD.
Apache License 2.0
19 stars 9 forks source link

bump k6 version to 0.51.0 and go version to 1.21 #11

Closed kempsterc closed 1 month ago

kempsterc commented 1 month ago
kempsterc commented 1 month ago

@LeonAdato would you mind reviewing please?

LeonAdato commented 1 month ago

@kempsterc sorry for the delay. I'm traveling and speaking at events this week and probably won't be able to review until early next week.

kempsterc commented 1 month ago

Ah! Apologies. At least I know now :). Thank you kindly! No rush at all. Just saw an opportunity to help

kempsterc commented 1 month ago

@kempsterc appears good to me! Thanks!

Verified using the following steps:

  • Checkout branch using gh pr checkout 11
  • Build k6 with updated extension using make
  • Confirmed k6 version upgrade using ./k6 version
  • Start a StatsD target of a Graphite server using the Docker Compose file, docker compose up
  • Executed test script with new binary using ./k6 run -o output-statsd examples/ramping-vus.js
  • Confirmed in Graphite UI (http://localhost:80/) that updates were coming into the instance

I followed the steps above, before I pushed

kempsterc commented 1 month ago

@javaducky @LeonAdato can we merge this one please? many thanks

nicholaspshaw commented 1 month ago

@javaducky @LeonAdato is there a release planned for any time soon?

kempsterc commented 1 month ago

@nicholaspshaw probably needs https://github.com/LeonAdato/xk6-output-statsd/pull/12 then release

LeonAdato commented 1 month ago

I'm traveling home today but will review and merge tomorrow when I'm back at my desk.

Thank you for the help! ( And patience!)