LeonAquitaine / tos-laimas-compass

A companion tool for the completionist Revelator
MIT License
12 stars 2 forks source link

Laimas overwrites existing addonloader.lua #3

Open Wolf1030 opened 8 years ago

Wolf1030 commented 8 years ago

so yea i'm using alot of addons,but with only one loader as it loads all .lua extensions in their sub-folders. Your app overwrites it on launch effectively disabling the other addons. Might need to remove your addonloader and use Fiote's (https://github.com/fiote/treeofsavior-addons) as his is the one that loads all the lua's. I've added your lua's code to his and it loads everything, but of course the app doesn't get updated and thus, only way to make it update properly is to relaunch it which makes it overwrite the addonloader.

LeonAquitaine commented 8 years ago

Thanks for trying it out, @Wolf1030 . Now this is odd - the loader provided does exactly the same thing as Fiote's, dynamically scanning the add-on directories, before trying to load them all (this is the setup I have on my test machine, where I load 16 add-ons at boot time.)

As a temporary work-around, just copy Fiote's to the application's Assets folder and overwrite the version there. The app will try to check and sync this file every time it loads.

Thanks for your suggestion, though - I'll test Fiote's current version, and if there's no issues I'll incorporate it.

Wolf1030 commented 8 years ago

roger that, i'll give it a test as I saved the edit in an rar file just in case it kept doing that.

Wolf1030 commented 8 years ago

@LeoLombardi For some reason, 2 things,

Adding a pastbin of the addonloader I'm trying use that the app that's overwriting even when its in the asset folder.

Edited Addonload http://pastebin.com/41eTbzLg

Wolf1030 commented 8 years ago

Ok, I remember what I did this morning now. So I had Fiote's addonloader, loaded up the game, got ingame and loaded the addon's. Then I launched your application, which overwrote the addonloader. I noticed then that my red fog addon for the minimap stopped updating. Thats when I went into the ToS directory and saw the addonloader was changed and assumed that was what was causing it to not update and could no longer use any slash commands. Atm, only the slash commands are not working when I just use your addonloader. Everything else works.

LeonAquitaine commented 8 years ago

@Wolf1030 If that's not too much trouble, could you list the add-ons you're using? I want to set up a test environment and reproduce the behavior. And thanks for the feedback!

Wolf1030 commented 8 years ago

@LeoLombardi Of course.

http://puu.sh/p00ID/1285d4a3a2.png took a screenshot for ya.

Wolf1030 commented 8 years ago

I also noticed that the exp tracker from Fiote that posts in chat how much exp you gained is also not showing up, assume thats another loader issue.

LeonAquitaine commented 8 years ago

@Wolf1030 Just updated my addons from Fiote, will observe its behavior - thanks for reporting!

Questionguy663 commented 8 years ago

Just as a second test subject, I also have lots of addons and I do have this problem aswell, everything works normally using Fiote's loader but only Excrulon pack addons are working with your addonloader :(

Addons that differ: I do not have lkchat, Minimapextra, extendedui, tagetinfo and Refresh I do have classicchat, cwCleric, NowPlaying, removefpscounter, removemapbackground , removepetinfo, Toggleduels and Buffcenter

I will say that Minimap Extra is a mod you don't need anymore Wolf1030 as the creator Mei0 bundled it into Excrulon's mapfogveiwer.

So yep second person pitching in, here is a shortlist of addons that won't load with your current addonloader: Fiote cwAPI CwFarmed cwShakeness

Mei0 noplaying removepetinfo toggleduels

Tried loading the game first with fiotes addonloader and then starting your program, workaround failed as the addons all load correcly but monster kills do not update on your addon

Workaround found: Keep playing, change maps, get some new kills, tracking resumed. I did need to put the fiote zip addonloader back the next day though and start the cycle again