LeonStaufer / material-dokuwiki

A material design template for DokuWiki
https://www.dokuwiki.org/template:material
Other
38 stars 10 forks source link

Errors with the W3C validator : <button> inside <a> tags #49

Open mkrtchian opened 4 years ago

mkrtchian commented 4 years ago

When I try the code of a wiki page in the W3C HTML validator, it shows some errors about buttons in <a> tags :

The element button must not appear as a descendant of the a element.

For buttons like here.

We can probably remove the <button> tags to let only the wrapping <a> tags but I guess they add some styling from material CSS, so some changes should be also done about that to keep the current styling. I haven't tried to change this yet.

LeonStaufer commented 4 years ago

Yes, this is an issue, mainly of semantic nature though, because it doesn't cause a problem in modern browsers.

I agree, that it would be better to only use <a> tags, but this would require porting a lot of styles from MDL. To be honest, I'm not sure if that's worth it.

A better solution might be using something such as upgradeDom to consistently update all components of the webpage to be inline with the MDL spec.