Builds after v0.28.x fail because patches fail to apply

LeonardLaszlo / nw.js-armv7-binaries

NW.js ARMv7 and ARMv8 binaries and the scripts for building and running the executable.

145 stars 22 forks source link

Closed LeonardLaszlo closed 5 years ago

LeonardLaszlo commented 5 years ago

@jtg-gg @rogerwang do you know why applying the patches step is failing since v0.28.x? https://gist.github.com/LeonardLaszlo/11080065fa8434252345728dd8ed8d5b

LeonardLaszlo commented 5 years ago

the problem seems to be that nwjs/src/third_party/node-nw is not a git repo

LeonardLaszlo commented 5 years ago

I solved this issue by cloning https://github.com/nwjs/node into $NWJS/src/third_party/node-nw directory.

common.gypi was moved from build directory to the root of the repo so I needed to change:

python build/gyp_chromium -Goutput_dir=out_gn_arm -I third_party/node-nw/common.gypi third_party/node-nw/node.gyp

rogerwang commented 5 years ago

Thanks. Any further issue please let me know.