LeonardLaszlo / nw.js-armv7-binaries

NW.js ARMv7 and ARMv8 binaries and the scripts for building and running the executable.
145 stars 22 forks source link

It seems a typo in build script #27

Closed DzmitryT closed 5 years ago

DzmitryT commented 5 years ago

Hello, i'm trying to build ARM binaries using your script and got an error on patches applying.

Apply node.patch in /home/dev/nwjs/src/third_party/node-nw ... patch directory is not a repository root. ERROR: This patch failed to apply. Your build will not be correct.

It seems like a typo in build script, line: getOrUpdateGitRepository "https://github.com/nwjs/node" "$NWJS/src/third_party/node" should be something like this: getOrUpdateGitRepository "https://github.com/nwjs/node" "$NWJS/src/third_party/node-nw" Isn't it?

UPD: After opening the issue I saw that is a duplicate of already closed issue, i'm sorry