search

LeonardSchmiester / Benchmark-Models

This repository is not maintained anymore. Please use: https://github.com/Benchmarking-Initiative/Benchmark-Models-PEtab
BSD 3-Clause "New" or "Revised" License
8 stars 5 forks source link

Visualization #66

Closed erikadudki closed 5 years ago

MerktSimon commented 5 years ago

This pull request is currently also part of PEtab. So question would be, if this routine should stay part of the benchmark models or access over PEtab is sufficient

yannikschaelte commented 5 years ago

I would also suppose that it makes no sense to have this duplicated functionality in here. @MerktSimon @erikadudki The python code can be deleted, but the simulationSpecification files need to be preserved, right?

MerktSimon commented 5 years ago

visualizationSpecification_Isensee_JCB2018_2.tsv ist still needed even if the routine runs as part of PEtab since it is model specific (i think the other file is just an old version with a mistake). Goal would be to get such visualization files for all the models.

yannikschaelte commented 5 years ago

Could you delete the duplicate python files then and only keep the needed visuSpec files? Then this pull request would be ready to merge