search

LeonardSchmiester / Benchmark-Models

This repository is not maintained anymore. Please use: https://github.com/Benchmarking-Initiative/Benchmark-Models-PEtab
BSD 3-Clause "New" or "Revised" License
8 stars 5 forks source link

Additional model: Alkan_DDRP_SciSignal2018 #72

Closed erikadudki closed 4 years ago

erikadudki commented 5 years ago

a new model in the d2d-examples exist https://github.com/Data2Dynamics/d2d/tree/master/arFramework3/Examples/Alkan_DDRP_SciSignal2018 maybe adding to the Benchmark-collection?

LaraFuhrmann commented 4 years ago

Corrected input parameters

dweindl commented 4 years ago

What's the reason for the NaN measurements included here? https://github.com/LeonardSchmiester/Benchmark-Models/blob/hackathon/hackathon_contributions_new_data_format/Alkan_SciSignal2018/measurementData_Alkan_SciSignal2018.tsv#L488

LeonardSchmiester commented 4 years ago 
Missing parameter(s) in parameter table: {'Wip1_mRNA_fold', 'yH2AX_au', 'pATM_au', 'tp53_au', 'pDNAPK_au', 'pChk1_au', 'tp21_au', 'pChk2_au', 'p21_mRNA_fold', 'pp53_au'}
Not OK

Seems like for every observable, there exists a parameter observable_ID and a parameter ID @LaraFuhrmann: Can you take care of this?

LaraFuhrmann commented 4 years ago 
Missing parameter(s) in parameter table: {'Wip1_mRNA_fold', 'yH2AX_au', 'pATM_au', 'tp53_au', 'pDNAPK_au', 'pChk1_au', 'tp21_au', 'pChk2_au', 'p21_mRNA_fold', 'pp53_au'}
Not OK

Seems like for every observable, there exists a parameter observable_ID and a parameter ID @LaraFuhrmann: Can you take care of this?

I deleted the parameters with only ID inn the SBML, since they were not used. Now there are only parameters observable_ID.

LeonardSchmiester commented 4 years ago

Thank you! Import works fine now :+1: