search

LeonardSchmiester / Benchmark-Models

This repository is not maintained anymore. Please use: https://github.com/Benchmarking-Initiative/Benchmark-Models-PEtab
BSD 3-Clause "New" or "Revised" License
8 stars 5 forks source link

issue with measurement data in Bruno_JExpBio2016 #95

Closed fbergmann closed 4 years ago

fbergmann commented 4 years ago

the newly added data sets model1_data3 and model1_data6 seem to be in the wrong scale.

LeonardSchmiester commented 4 years ago

What do you mean exactly? Measurement values are all positive and as far as I can see it, there were no newly added datasets in the measurement file

fbergmann commented 4 years ago

All simulations in that model are in the range of 0..4 the data in data3 and data6 are however in the range of 0...2800 ... so they don't match. this happened in commit

dda334ad97fd8a15abcb8f79fb4dd3410dfc98ff

LeonardSchmiester commented 4 years ago

Ah true. Apparently, the . got lost on the way there. Thank you for pointing that out. @LaraFuhrmann I think you have to change your decimal seperator settings. Can you revert the changes and also check for other models, that you worked on.

LeonardSchmiester commented 4 years ago

Same issue for swameye at the moment

LeonardSchmiester commented 4 years ago

Swameye and Bruno are fixed now.