search

Leonardo2718 / lua-vermelha

A Lua implementation with an Eclipse OMR based JIT compiler
89 stars 8 forks source link

Chinese translation of the documentation #26

Closed leejingbo closed 7 years ago

leejingbo commented 7 years ago

I finished the Chinese translation of the documentaion as I said in issue #25 .

The filename ends with _zh.md .

Leonardo2718 commented 7 years ago

LGTM as far as I can tell.

@xliang6 ?

xliang6 commented 7 years ago

I will review this today.

xliang6 commented 7 years ago

Looks good to me. One small suggestion: We may want to squash all these commits into one before merging?

Leonardo2718 commented 7 years ago

I don't mind having one commit per "logical unit of translation". So I'm okay with one commit per file. But I don't like having multiple commits for one file. So @leejingbo, would you mind squashing those together?

leejingbo commented 7 years ago

@Leonardo2718 I rebased my repo and squashed the commits.

@xliang6 Thank you for your suggestion !