search

LeonardoCardoso / SwiftLinkPreview

It makes a preview from an URL, grabbing all the information such as title, relevant texts and images.
https://leocardz.com/swift-link-preview-5a9860c7756f
MIT License
1.37k stars 196 forks source link

Correctly rebase relative image URLs from the final URL. #136

Closed lhunath closed 3 years ago

lhunath commented 3 years ago

Fixed

For them to be valid URLs that the application can use to request the actual image, they need to be resolved against the original request URL.

eg.

finalURL: "https://foo.com/quux/help.htm?s=x", image: "img/photo.jpg" -> image: "https://foo.com/quux/img/photo.jpg"

LeonardoCardoso commented 3 years ago

Thanks, @lhunath. I will check it out ASAP and merge it.

lhunath commented 3 years ago

Thanks, @lhunath. I will check it out ASAP and merge it.

Any chance you might find a moment of free time to evaluate this?

LeonardoCardoso commented 3 years ago

@lhunath Not really. I will try to find a time slot soon.