LeonardoGentile / mobx-router5

Router5 integration with mobx
MIT License
22 stars 7 forks source link

Copy typings file to dist #13

Closed omerman closed 6 years ago

omerman commented 6 years ago

Copying the typings file to dist as part of the build.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 71.739% when pulling 0385c7bd2bb1bcf85a6099f599b6f8839b699d3d on omerman:add-typings-file-to-dist into d8bbc9b961cb29f3147972b5797cb7a254bca6b7 on LeonardoGentile:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 71.739% when pulling 0385c7bd2bb1bcf85a6099f599b6f8839b699d3d on omerman:add-typings-file-to-dist into d8bbc9b961cb29f3147972b5797cb7a254bca6b7 on LeonardoGentile:master.

LeonardoGentile commented 6 years ago

Apparently this is still randomly failing on travis after I've integrated it in my branch. At this point I think it's something travis-related.. but I'm not sure what/why

omerman commented 6 years ago

It happens when Travis runs more than once on the same branch

LeonardoGentile commented 6 years ago

Really? Why should it? It's now failing on node 6 because it can't find eslint..?

sh: 1: eslint: not found
npm ERR! Linux 4.14.12-041412-generic
npm ERR! argv "/home/travis/.nvm/versions/node/v6.14.4/bin/node" "/home/travis/.nvm/versions/node/v6.14.4/bin/npm" "run" "lint"
npm ERR! node v6.14.4
npm ERR! npm  v3.10.10
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR! mobx-router5@0.0.0-development lint: `eslint src test tools`
npm ERR! spawn ENOENT
npm ERR! 
npm ERR! Failed at the mobx-router5@0.0.0-development lint script 'eslint src test tools'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the mobx-router5 package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     eslint src test tools
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs mobx-router5
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls mobx-router5
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /home/travis/build/LeonardoGentile/mobx-router5/npm-debug.log
The command "npm run lint" exited with 1.

I think it's a travis problem.

How would you fix this? Make another fake commit and run it again?

omerman commented 6 years ago

Well it is not what we saw earlier.. But what solved it for me was to close the pr and open another one. So Im not really sure how should you proceed.. maybe open a branch with the changes, push it, and then merge to master?

omerman commented 6 years ago

If nothing works, maybe give up on the node 6 checks temporarily, and report to Travis :X?

I saw this Issue on Travis..

LeonardoGentile commented 6 years ago

:tada: This PR is included in version 4.2.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

LeonardoGentile commented 6 years ago

it was totally a travis problem, by purging the cache each time it temporarily fixed the following build 🙄