Closed AndrewArlenHoneywell closed 4 years ago
LeonardoGentile
commented
4 years ago Hello @AndrewArlenHoneywell The build is failing, I guess you didn't run eslint and test? Would you take a look and correct please? https://travis-ci.org/LeonardoGentile/react-mobx-router5
AndrewArlenHoneywell
commented
4 years ago Sure .
Thank you for merging. I will look at the build failure ASAP
Regards Andrew
From: LeonardoGentile [mailto:notifications@github.com] Sent: Thursday, 13 February 2020 2:24 AM To: LeonardoGentile/react-mobx-router5 react-mobx-router5@noreply.github.com Cc: Arlen, Andrew Andrew.Arlen@Honeywell.com; Mention mention@noreply.github.com Subject: [External] Re: [LeonardoGentile/react-mobx-router5] custom error view component (#13)
Hello @AndrewArlenHoneywellhttps://github.com/AndrewArlenHoneywell The build is failing, I guess you didn't run eslint and test? Would you take a look and correct please? https://travis-ci.org/LeonardoGentile/react-mobx-router5
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/LeonardoGentile/react-mobx-router5/pull/13?email_source=notifications&email_token=ACS3JKJKV53RVVAWYZNVWDTRCQIAVA5CNFSM4KJ5LNU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELRFIMA#issuecomment-585258032, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACS3JKLRSYSXA6CAQ47FPRDRCQIAVANCNFSM4KJ5LNUQ.
AndrewArlenHoneywell
commented
4 years ago Hi hi
Thank you again for taking the time to merge the branch. Here is a pull request that fixes the build.
https://github.com/LeonardoGentile/react-mobx-router5/pull/14
Sorry for the inconvenience
Regards Andrew
From: LeonardoGentile [mailto:notifications@github.com] Sent: Thursday, 13 February 2020 2:24 AM To: LeonardoGentile/react-mobx-router5 react-mobx-router5@noreply.github.com Cc: Arlen, Andrew Andrew.Arlen@Honeywell.com; Mention mention@noreply.github.com Subject: [External] Re: [LeonardoGentile/react-mobx-router5] custom error view component (#13)
Hello @AndrewArlenHoneywellhttps://github.com/AndrewArlenHoneywell The build is failing, I guess you didn't run eslint and test? Would you take a look and correct please? https://travis-ci.org/LeonardoGentile/react-mobx-router5
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/LeonardoGentile/react-mobx-router5/pull/13?email_source=notifications&email_token=ACS3JKJKV53RVVAWYZNVWDTRCQIAVA5CNFSM4KJ5LNU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELRFIMA#issuecomment-585258032, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACS3JKLRSYSXA6CAQ47FPRDRCQIAVANCNFSM4KJ5LNUQ.
Added support to pass in a custom view for an error component, so that the error message can be more sophisticated than a simple message.