Open LeonardoViotti opened 3 years ago
The main priority would be to improve app speed since it is too slow in the server.
Othe minor issues that would be good to solve:
here()
or something similar in app.R so that you don't have to change path and working directory.This commit; https://github.com/LeonardoViotti/code-review/commit/498e4f1f839133b9645876a95b21d754bee58eab contains the following code changes to improve app speed:
Most of the changes were included in the ui.R
script.
conditionalPanel("input['geo_agg'] == 'Province'"
. Weirdly enough, this shouldn't be the main reason why it nows behaves correctly. conditionalPanel
for multiple product. One of the reasons is that, as far as I understood the graphs, this should be made only at the Country Level rather than the Provide or Country Level. The province level plot takes four different provinces and plot them, if we include the select multiple it breaks the graphs. Therefore I changed the condition to be present only if Country is selected as follows: conditionalPanel(
condition = "input['geo_agg'] == 'Country'",
checkboxInput("multiProd", label = "Select multiple products", value = FALSE)
)
Before, the condition was
condition = "input.province.length < 2 && input.product_brand.length < 2",
Ths <2
was causing the panel to be excluded if more provinces were selected.
I have deployed the app to my personal shinyapps server here: https://rrmaximiliano.shinyapps.io/RFR-PS-dashboard/ I will delete it after your revision.
Published version of dashboard: https://datanalytics.worldbank.org/connect/#/apps/376/info