LeonardoViotti / code-review

0 stars 0 forks source link

RFR-PS-dashboard #2

Open LeonardoViotti opened 3 years ago

LeonardoViotti commented 3 years ago

Published version of dashboard: https://datanalytics.worldbank.org/connect/#/apps/376/info

LeonardoViotti commented 3 years ago

The main priority would be to improve app speed since it is too slow in the server.

Othe minor issues that would be good to solve:

RRMaximiliano commented 3 years ago

This commit; https://github.com/LeonardoViotti/code-review/commit/498e4f1f839133b9645876a95b21d754bee58eab contains the following code changes to improve app speed:

Most of the changes were included in the ui.R script.

conditionalPanel(
    condition = "input['geo_agg'] == 'Country'",
    checkboxInput("multiProd", label = "Select multiple products", value = FALSE)
)

Before, the condition was

condition = "input.province.length < 2 && input.product_brand.length < 2",

Ths <2 was causing the panel to be excluded if more provinces were selected.

I have deployed the app to my personal shinyapps server here: https://rrmaximiliano.shinyapps.io/RFR-PS-dashboard/ I will delete it after your revision.