Update deprecated:`events.EventEmitter` to `events` in parser

Leonidas-from-XIV / node-xml2js

XML to JavaScript object converter.

MIT License

4.88k stars 604 forks source link

Update deprecated:`events.EventEmitter` to `events` in parser #492

Closed arorayash closed 5 years ago

arorayash commented 5 years ago

As far as I'm aware the events.EventEmitter has been deprecated in favor of simply events. However, events.eventEmitter is still being used in /src/parser.coffee

Leonidas-from-XIV commented 5 years ago

Do you have a source for that? In the current documentation it does say events (so I think this change makes sense in general) but no note about any deprecation or when that was even introduced.

Leonidas-from-XIV commented 5 years ago

Anyway, I tested it on the currently supported versions of Node and it works, so no reason not to merge it. Thanks!