Make default settings immutable

Leonidas-from-XIV / node-xml2js

XML to JavaScript object converter.

MIT License

4.88k stars 602 forks source link

Make default settings immutable #536

Open ramya0820 opened 4 years ago

ramya0820 commented 4 years ago

The default settings are mutable resulting in potential unintended overriding of configurations. Can consider making them immutable as a better safeguard on their access.

Leonidas-from-XIV commented 4 years ago

That's a good point, would indeed be better. Can you submit a PR that works on all supported Node versions?