Migrate to xmlbuilder2?

Leonidas-from-XIV / node-xml2js

XML to JavaScript object converter.

MIT License

4.87k stars 601 forks source link

Migrate to xmlbuilder2? #576

Open Richienb opened 4 years ago

Richienb commented 4 years ago

The creator of the original xmlbuilder package, @oozcitak has reworked it to create xmlbuilder2. Should we migrate to it?

Useful resources

Upgrading from xmlbuilder

// @Leonidas-from-XIV

Leonidas-from-XIV commented 4 years ago

What would be the advantages for xml2js?

Richienb commented 4 years ago

@Leonidas-from-XIV https://oozcitak.github.io/xmlbuilder2/upgrading-from-xmlbuilder.html#comparison-with-xmlbuilder

Leonidas-from-XIV commented 4 years ago

I looked at this and couldn't find any tangible improvements, hence my question.

boulaya66 commented 3 years ago

Major improvement: get rid of circular dependency ! (XMLNode.js -> XMLxxxx.js -> XMLNode.js => rollup fail)

szakharchenko commented 3 years ago

It turned out to be simplest to just migrate a whole library I never touched before from xml2js to xmlbuilder2 to get rollup to work. So, in a way, there truly aren't any advantages for xml2js.