Ocaml 4.03 - Githubissues

Leonidas-from-XIV / slacko

A neat interface for Slack

https://leonidas-from-xiv.github.io/slacko

Other

81 stars 11 forks source link

Closed jerith closed 7 years ago

jerith commented 7 years ago

This adds a Travis build for OCaml 4.03 (and also latest, which seems to still be 4.02).

In order to build on 4.03 we need ppx_deriving_yojson>=3.0, which requires changes to the result type.

I also ~pinned conduit to 0.14.0~ added a conflict with conduit 0.14.1 because of https://github.com/mirage/ocaml-conduit/issues/189 which has been fixed but not yet released.

Leonidas-from-XIV commented 7 years ago

This looks very good, thanks! Did'nt know you can have global flags. Can you address these small issues before I merge it?

Could you squash the version-pinned, opam pinned and conflict commits into one, resulting in just one commit which only uses an opam conflict? That would avoid merging a bit of historical baggage.
Could you also add OCaml 4.04 while at it?
Can you update the URL of the travis script to https://raw.githubusercontent.com/ocaml/ocaml-ci-scripts/master/.travis-opam.sh while at it? There is a redirect, but we can cut the middle man while updating the CI config.

Looking forward to the changes. I haven't really rebuilt it on travis for a long time, quite a few things have changed.

jerith commented 7 years ago

Would you like me to squash any other commits? There are a few that might make sense to combine, but you didn't mention them so I didn't do it. :-)

Leonidas-from-XIV commented 7 years ago

If you want to, you could squash 68218f6, 19781eb, eb785e0 and 342638a if you want to. I'll leave that up to you, I'm okay either way.

jerith commented 7 years ago

I squashed the first three, git wasn't happy about moving the last commit around.

Leonidas-from-XIV commented 7 years ago

Merged, thank you!

jerith commented 7 years ago

Thanks!