search

Leonidas-from-XIV / slacko

A neat interface for Slack
https://leonidas-from-xiv.github.io/slacko
Other
81 stars 11 forks source link

Add support for message attachments #13

Closed jerith closed 7 years ago

jerith commented 7 years ago

This pull request addresses #11.

I haven't given much thought at all to API design in the initial implementation here, I just hacked in some types and functions to get something more or less working.

Leonidas-from-XIV commented 7 years ago

Looking forward to reviewing it! Can you squash these two commits?

jerith commented 7 years ago

Done.

Leonidas-from-XIV commented 7 years ago

(Sorry for the noise, I rarely review on GitHub, therefore I am not super familiar with the process)

jerith commented 7 years ago

Thanks for the review, I'll push some updates a little later today.

Are you happy with the new types and functions for working with them? They're not particularly consistent with the rest of the Slacko API, but I don't really have any good ideas for cleaning that up.

jerith commented 7 years ago

I think I've addressed all the comments in this round of review.

jerith commented 7 years ago

Ready for the next round of review. :-)