search

Leonidas-from-XIV / slacko

A neat interface for Slack
https://leonidas-from-xiv.github.io/slacko
Other
81 stars 11 forks source link

Add public_name to slacko library and don't wrap it. #24

Closed paurkedal closed 6 years ago

paurkedal commented 6 years ago

The current master does not provide the library as a public API (e.g. if pinning its --dev-repo).

Leonidas-from-XIV commented 6 years ago

Oh, yeah, it should definitely have a public_name, sorry for the omission!

But I am a bit surprised why you would disable the wrapping? From what I see, it should be fine to wrap it, which is the default for jbuilder without the library accidentally being moved into Slacko.Slacko.

Leonidas-from-XIV commented 6 years ago

I've merged it without wrapped false and it seems to be fine, but if I missed something and broke it please let me know!

paurkedal commented 6 years ago

Thanks, I assumed wrapping was not intended since there is only one top-level module, but either works for me.