search

Leonidas-from-XIV / slacko

A neat interface for Slack
https://leonidas-from-xiv.github.io/slacko
Other
81 stars 11 forks source link

Handle optional fields in user_obj #36

Closed Khady closed 5 years ago

Khady commented 5 years ago

When a user is deleted, most of the fields of user_obj are optional. I used default values most of the time because I think they make sense and reduce the breakage of the interface. But I can make all the fields optional if you prefer.

Khady commented 5 years ago

CI doesn't pass, but it doesn't seem related to my changes.

Khady commented 5 years ago

Gentle ping @Leonidas-from-XIV

Leonidas-from-XIV commented 5 years ago

Looks like dune changed the path where it builds modules so our brittle house of cards stopped working. I'll have to find a better solution for this.

Leonidas-from-XIV commented 5 years ago

Okay, #37 should fix the tests.

Leonidas-from-XIV commented 5 years ago

I've merged a rebased version of this branch, thanks for your contribution!

Khady commented 5 years ago

Thanks!