Remove deprecation warnings for recent versions of yojson

Leonidas-from-XIV / slacko

A neat interface for Slack

https://leonidas-from-xiv.github.io/slacko

Other

81 stars 11 forks source link

Closed williamhammond closed 4 years ago

williamhammond commented 4 years ago

Ran into this when trying to add some new features for a recent version of Slack. Using Yojson.Safe.json is depreciated as of https://github.com/ocaml-community/yojson/releases/tag/1.6.0

Leonidas-from-XIV commented 4 years ago

Yeah, I am sort of aware of that change since it was me who wrote that code in Yojson.

The PR looks okay, thanks! Though, you need to adjust the opam file to depend on yojson {>= "1.6.0"}, otherwise it will break for older versions.

williamhammond commented 4 years ago

yeah I saw it was you :). I'll update the version

Leonidas-from-XIV commented 4 years ago

Looks good, passes CI, ready to go. Thanks!