search

LeonieBorne / plstuto

Tutorials to apply cross decomposition methods in python
MIT License
7 stars 8 forks source link

first attempt for cca data simulation #12

Closed nadinespy closed 4 years ago

LeonieBorne commented 4 years ago

Thanks @nadinespy, that's great! Before we accept the PR, can you add some text in your tutorial? I think it would be much easier to follow with an introduction (to understand the goal of the tutorial, e.g. "see the influence of the dataset on the ouput of the CCA algorithm"?) and more comments (e.g. to what correspond each plot?).

nadinespy commented 4 years ago

Good morning, Leonie! Yeah, sure, I have commented on this notebook in the mattermost channel a bit more (in the wrap-up for the EMEA hub), and it's super clear to me that it needs documentation/explanations. :-D I made a pull request already yesterday so that anyone who already wants to have a look at it can do that. Will work on the explanations now.

LeonieBorne commented 4 years ago

@nadinespy I will close this pull request as you did a new one with the additional comments. Thanks!! :)