Awww it's so fuzzy! - Githubissues

LeopoldArkham / Molten

[WIP] Molten - Style-preserving TOML parser.

Apache License 2.0

40 stars 8 forks source link

Awww it's so fuzzy! #49

Open killercup opened 6 years ago

killercup commented 6 years ago

Re: https://github.com/LeopoldArkham/Molten/pull/40#issuecomment-349012966

This PR

adds some fuzzer documentation/introduction,
runs fuzzer with debug assertions (they should really hold),
and finally adds a Travis build that does nothing but run the fuzzer for 20s. I think it's a good idea to make this fail the build: It's easy to overlook otherwise and the fuzzer seems pretty stable right now, so it'll probably find actual bugs in the future. We can pin the nightly to a specific version to make it even more stable.

killercup commented 6 years ago

Ha, and it fails. No idea what this means specifically, especially since the base64 it outputs is empty.

==7231==HINT: For debugging, try setting environment variable LSAN_OPTIONS=verbosity=1:log_threads=1

I guess I'm gonna do that then.

Also, 20s seems to be on 152,096 runs and a coverage of 1753 code paths. With some demo files, it goes up to 2467 on my machine. I'll increase it to 60 seconds for now, and maybe we can copy the toml files already used in tests as corpus as well.

killercup commented 6 years ago

You've got to be kidding me. ==7641==LeakSanitizer has encountered a fatal error. even though I disabled it with -detect_leaks=0…

@manishearth, you managed to get cargo-fuzz's CI running. What dark magic did you use? Does using GCC5 make the difference? Is it because I forgot to do this last week when there as a super moon?

Manishearth commented 6 years ago

nooooo idea

LeopoldArkham commented 6 years ago

My thoughts are with you at this difficult time. Summon the eldritch powers, Pascal!