LeraRiemann / ProjectInfinity

https://modrinth.com/mod/infinite-dimensions
9 stars 5 forks source link

Throwing [Book and Quill] Item Into Nether Portal Crash the Game and Makes SaveFile UnLoadAble #47

Open Horizoll opened 3 weeks ago

Horizoll commented 3 weeks ago

Fabric 1.21.1

LeraRiemann commented 3 weeks ago

Please provide the logs - for the crash part and for a game session where you try to open the unloadable file

Horizoll commented 3 weeks ago

crash-2024-10-03_11.39.08-server.txt

crash-2024-10-03_11.46.41-server.txt

LeraRiemann commented 3 weeks ago

are you throwing an empty book and quill or does it have text in it? the crash suggests the first

Horizoll commented 3 weeks ago

Yes, I occasionally threw empty book and quill into nether portal

LeraRiemann commented 3 weeks ago

okay then i think i know exactly what is wrong! will fix it once i'm home ^^

LeraRiemann commented 2 weeks ago

should be fixed in 1.12.4 of the mod! let me know if it is!

syntience commented 2 weeks ago

i had a similar thing happen in 1.20.1, mod version 1.11.1, after throwing a book from the library dimension into a portal crash-2024-10-07_17.10.58-server.txt crash-2024-10-07_17.35.59-server.txt error log after trying to join world: https://mclo.gs/jYeElrj

edit: huh, i think this might've been because i had a mod(s) disabled in modrinth. after i removed those mods from the modpack and deleted their folders in config/infinity/modular, i'm not getting the crash anymore

edit 2: or not nvm crash-2024-10-07_20.37.41-server.txt

edit 3: also got this crash when two players threw books into two separate portals at the same time, or tried to enter different portals at the same time

LeraRiemann commented 2 weeks ago

smells interesting "not a number: 245L" why is it trying to write a long down huh will try to fix this once home! though this fix will be in a 1.21.1 version

LeraRiemann commented 2 weeks ago

actually

it fails to parse noise settings so most probably there's a biome in one of the mods that has a custom surface rule which contains longs in it! fascinating!

yeah i know exactly how to fix this

for now, you can look what biome's causing this and disable it manually (if you don't know how, you can send me the datapack that causes this error and i'll sniff it out for you)

syntience commented 2 weeks ago

though this fix will be in a 1.21.1 version

oof sadge, i'll have to update my modpack then

for now, you can look what biome's causing this and disable it manually (if you don't know how, you can send me the datapack that causes this error and i'll sniff it out for you)

would i be able to send a modrinth export of the modpack? also how do you want me to send it to you?

thanks for looking into it!

LeraRiemann commented 2 weeks ago

Should be fixed in 1.13.0 which just released. Before checking if the fix worked, please backup&delete config/infinity/modular and let it regenerate: it most probably had broken files in it that will be fixed on regeneration.

In terms of what you can send & how: i need a broken datapack from the datapacks folder, if you can't figure out which one's broken you can just archive & send the entire folder, or you can send the config/infinity/modular folder the same way (over discord for example), but if the fix worked it isn't necessary.

syntience commented 1 week ago

crash-2024-10-12_18.15.41-server.txt i also had this crash. same cause as the other one, and also renders a world unloadable datapacks.zip and here's the datapack folder from one of these worlds