Lerc / canvas_tab

ComfyUI canvas editor page
BSD 2-Clause "Simplified" License
156 stars 19 forks source link

404 not found #2

Closed otterslide closed 9 months ago

otterslide commented 11 months ago

I downloaded the module, added it to custom_nodes, then added the node, and click "Edit". It launches "http://127.0.0.1:8188/extensions/canvas_tab/page/index.html" which gives "404: Not Found" any idea what I'm doing wrong? Thanks.

otterslide commented 11 months ago

I got it working by copying the module to "ComfyUI/web/extensions/canvas_tab" as well.. I have it both in custom_nodes and in web/extensions. Was this the proper way to install it?

Lerc commented 11 months ago

Ah, I should update the instructions, I took out the bit that auto set that up when I changed it to be installed by comfy manager. If you install with comfy manager this step won't be necessary. https://github.com/ltdrdata/ComfyUI-Manager

FreezaSama commented 9 months ago

Humm same happened to me just now out of the blue... the node shows up but cannot draw. the repository was reinstalled under web/extensions/canvas_tab ... still nothing. any ideas on how to bring it back up?

melMass commented 9 months ago

@Lerc FYI you can now just use the WEB_DIRECTORY top level variable (https://github.com/melMass/comfy_mtb/blob/90d96366c8b7637b55d1b4f88cb9aca217c1414b/__init__.py#L38) this get's picked up by comfy and avoid any moving/symlink

Lerc commented 9 months ago

It does that. https://github.com/Lerc/canvas_tab/blob/a3a7d03444cc604e78caf76d186a6ab99573e156/__init__.py#L135

I thought that was a property of comfy manager. Does ComfyUI itself handle WEB_DIRECTORY?

melMass commented 9 months ago

Oh I'm blind sorry. Yes that's what I meant, it's a comfy feature not a comfy manager one ;)

https://github.com/comfyanonymous/ComfyUI/commit/9b1d5a587cee63771c1184d0942093bf64b54d96

Lerc commented 9 months ago

OK, updated documentation to reflect that.