Closed alvyn279 closed 6 years ago
Is the addition of the __init__.py
into the base directory really necessary? After all the SA3 directory is not a module, only SA3/qa_web is a module. Feel free to correct me on this
After further investigation, the inclusion of SA3/__init__.py
is not necessary for the project to function. If there are no other reasons to keep it then I believe we should remove it.
:exclamation: No coverage uploaded for pull request base (
master@814b67b
). Click here to learn what that means. The diff coverage is75%
.
@@ Coverage Diff @@
## master #91 +/- ##
=========================================
Coverage ? 75.06%
=========================================
Files ? 8
Lines ? 381
Branches ? 45
=========================================
Hits ? 286
Misses ? 74
Partials ? 21
Impacted Files | Coverage Δ | |
---|---|---|
SA3/qa_web/wsgi.py | 0% <0%> (ø) |
|
SA3/qa_web/settings.py | 100% <100%> (ø) |
|
SA3/qa_web/urls.py | 100% <100%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 814b67b...012de65. Read the comment docs.
Moved
settings
,wsgi
andurl admin
configs up into mainqa_web
app, to avoid an abstract inner SA3 folder.I've tested the functionality of the website and all seems fine, but please take the time to test it out yourselves before reviewing! The components that were touched in the commit are extremely sensitive and critical for our app.