search

Lercerss / SOEN341W18

Software Process Winter 2018 Group Project - SA3
6 stars 2 forks source link

Fix question button on homepage #92 #94

Closed Lercerss closed 6 years ago

Lercerss commented 6 years ago

Remove conditional on href value of the "Click to ask a question" button found on the homepage. This way the question view's redirecting behaviour will occur correctly to ask the user to login.

codecov-io commented 6 years ago

Codecov Report

Merging #94 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #94   +/-   ##
=======================================
  Coverage   74.14%   74.14%           
=======================================
  Files           5        5           
  Lines         352      352           
  Branches       45       45           
=======================================
  Hits          261      261           
  Misses         70       70           
  Partials       21       21

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 08003df...f5a7599. Read the comment docs.

patrickvacca commented 6 years ago

lgtm, much simpler code