Lercerss / graphelier

TFBAG Capstone project 2019-2020
The Unlicense
5 stars 1 forks source link

[#192] Added python scripts for news fetcher #204

Closed alvyn279 closed 4 years ago

alvyn279 commented 4 years ago

** Will only scrape based on the instruments that are found in the graphelier-db

TODO: add keys.py on prod under graphelier/news/scripts/

Sample command:

python news_fetcher.py 01-29-2020 02-02-2020
Lercerss commented 4 years ago

Can you add a sample keys.py with a mock key to show the format expected? A bit like how projects usually include a .env.example

alvyn279 commented 4 years ago

Can you add a sample keys.py with a mock key to show the format expected? A bit like how projects usually include a .env.example

I added its format in the news README, is that fine ?

Lercerss commented 4 years ago

That works

Lercerss commented 4 years ago

Can we increase the coverage on https://1807-206399552-gh.circle-artifacts.com/0/htmlcov/news_fetcher_py.html? It's a bit low at 52%

alvyn279 commented 4 years ago

Can we increase the coverage on https://1807-206399552-gh.circle-artifacts.com/0/htmlcov/news_fetcher_py.html? It's a bit low at 52%

Updated PR, 76% coverage on relevant code is the best I could get up to in news_fetcher with dependency injection