Lerentis / terraform-provider-gitea

Terraform Provider for your Gitea Instance
https://registry.terraform.io/providers/Lerentis/gitea/latest
MIT License
22 stars 11 forks source link

implement repositories attribute to gitea_team #37

Closed yamadayutaka closed 1 year ago

yamadayutaka commented 1 year ago

This PR implements the repositories attribute to gitea_team resource.

Details: #36

yamadayutaka commented 1 year ago

Hi @Lerentis , Thank you for your review! I will check.

yamadayutaka commented 1 year ago

bump the version number by a minor release everywhere

Is it correct to bump the version from 0.12.3 to 0.13.0?

Lerentis commented 1 year ago

bump the version number by a minor release everywhere

Is it correct to bump the version from 0.12.3 to 0.13.0?

Yeah this should be fine as it is no breaking change

yamadayutaka commented 1 year ago

make the error handling in setTeamRepositories more explicit

Could you elaborate a bit more on your concerns?

Lerentis commented 1 year ago

make the error handling in setTeamRepositories more explicit

Could you elaborate a bit more on your concerns?

currently you just return on error != nil. it would be good to get a proper error message

yamadayutaka commented 1 year ago

I have done the following:

Lerentis commented 1 year ago

maybe i was not clear enough, so code is better than english : https://github.com/Lerentis/terraform-provider-gitea/commit/19062e27f0b57bdb56d4fe716af763dec3501c04

yamadayutaka commented 1 year ago

Thanks! I synced your commit.