Closed yamadayutaka closed 1 year ago
Hi @Lerentis , Thank you for your review! I will check.
bump the version number by a minor release everywhere
Is it correct to bump the version from 0.12.3 to 0.13.0?
bump the version number by a minor release everywhere
Is it correct to bump the version from 0.12.3 to 0.13.0?
Yeah this should be fine as it is no breaking change
make the error handling in setTeamRepositories more explicit
Could you elaborate a bit more on your concerns?
make the error handling in setTeamRepositories more explicit
Could you elaborate a bit more on your concerns?
currently you just return on error != nil. it would be good to get a proper error message
I have done the following:
setTeamRepositories
maybe i was not clear enough, so code is better than english : https://github.com/Lerentis/terraform-provider-gitea/commit/19062e27f0b57bdb56d4fe716af763dec3501c04
Thanks! I synced your commit.
This PR implements the
repositories
attribute togitea_team
resource.Details: #36