iat/exp fields and multiple identical kid

Les-Ateliers / bornepasse

0 stars 0 forks source link

iat/exp fields and multiple identical kid #2

Open Fab550010 opened 3 years ago

Fab550010 commented 3 years ago

Up re-reading your code I think I also saw two other issues (but I don't know anything about Python so I might be wrong, especially on the second) :

top level cbor has 2 fields, iat and exp that need to be checked (especially exp)
kid isn't guaranteed to be unique so signature checks should loop on all matching kid If I knew python I would create a module to my library to avoid duplicated efforts :(

hgshoggins commented 3 years ago

I must confess I'm far from being fluent in Python. I mostly came across this because a simple implementation example taken directly from https://github.com/ehn-dcc-development was using preexisting COSE and CBOR libraries in Python in their trivial implementation. Thanks, I will look into it.