search

Leseratte10 / acsm-calibre-plugin

Calibre plugin for ACSM->EPUB and ACSM->PDF conversion.
https://www.mobileread.com/forums/showthread.php?t=341975
GNU General Public License v3.0
600 stars 23 forks source link

fulfill.py doesn't accept any filename besides "URLLink.acsm" #18

Closed ghost closed 2 years ago

ghost commented 2 years ago

Bug description

I use fulfill.py directly to get books from .acsm files, without using Calibre. I noticed that fulfill.py only accepts .acsm files named "URLLink.acsm", and rejects any other filename. Is there a reason for this behavior? I think fulfill.py would be easier to use if it just accepted any .acsm filename.

Operating system

Linux

Which version of Calibre are you running?

none

Which version of the DeACSM plugin are you running?

0.0.15

Further information

No response

Leseratte10 commented 2 years ago

No real reason - the "fulfill.py" script is very old and I basically only used / needed it during development when I has the Python implementation of the Adobe stuff implemented but didn't yet have all the Calibre plugin hooks.

Should be fairly easy to add some kind of parameter to use a custom file name. I'm going to add that with the next version.

Leseratte10 commented 2 years ago

This is now included in fa6ad1da5d06a786be8ff5930e5a0988d82b9f40 and will be available in the next release. The fulfill.py script now takes multiple file names as parameters and will fulfill them all. If no file name is entered, it will still try to fulfill "URLLink.acsm".