search

Leseratte10 / acsm-calibre-plugin

Calibre plugin for ACSM->EPUB and ACSM->PDF conversion.
https://www.mobileread.com/forums/showthread.php?t=341975
GNU General Public License v3.0
653 stars 23 forks source link

Suggestion: Make an Icon in the Main Menu #32

Closed p1nkyy closed 2 years ago

p1nkyy commented 2 years ago

Hi, is it possible to have an icon in the Main Menu like Kindle Unpack does? This is for other feature like returning books, authorizing ADE, etc. Thanks for considering this!

Leseratte10 commented 2 years ago

This has already been suggested before on the Mobileread thread. This is possible but somewhat tricky. Usually, FileTypePlugins like mine are not able to have menu icons, so to get that to work I'd need to bundle two plugins in one ZIP - the FileTypePlugin that does the actual work and a GUI plugin that can have buttons and can then trigger the FileTypePlugin to do stuff.

It's on my to-do list but I haven't had time to look into that yet.

p1nkyy commented 2 years ago

Thanks for even considering this!

Leseratte10 commented 2 years ago

The newest commit of this plugin now has a rudimentary GUI button in the main toolbar that can A) open the settings dialog or B) directly open the loaned book list.

Note that that update also changed around a bunch of internals and is not well tested, so if you'd like to test that, you NEED to make a backup of your authorization before installing that beta.

https://github.com/Leseratte10/acsm-calibre-plugin/suites/8142173065/artifacts/353076906

p1nkyy commented 2 years ago

Thanks! Didn't realize this wiped all titles in loaned books list. Can they be restored using the backup?

Leseratte10 commented 2 years ago

Hm. I didn't change how the loaned book list worked with this update. Interesting that that would be wiped, I'll have to test that again. No, the authorization backup is just for the authorization, it doesn't include the loaned book list.

EDIT: This new version changes where the loaned book list is stored, though. There is migration code to move it from the old location to the new one. Did you change back from this test version to the old release or the older test version for the book return issue? In that case that version would fail to find the list.

p1nkyy commented 2 years ago

No, the book return issue was using the older beta, then I updated to this one and found the loaned book is empty. I have since processed more books and they (newer ones using v.0.0.17) show up fine. I think if I re-processed the older ACSMs, they should re-appear so it's not a big deal, just thought it's worth mentioning.

Leseratte10 commented 2 years ago

Definitely worth mentioning, this update is supposed to migrate all data including the loan list. Maybe that migration doesn't properly work on Windows, I've only tested that on Linux so far.