LeslieMcD
commented
7 years ago Thanks Joseph! I was so frustrated with the responsive aspects of the header area. Could you point me to a good source or two for responsive resources?
Open josephtkim opened 7 years ago
LeslieMcD
commented
7 years ago Thanks Joseph! I was so frustrated with the responsive aspects of the header area. Could you point me to a good source or two for responsive resources?
josephtkim
commented
7 years ago Sure Leslie! Here are some helpful resources on flex:
css-tricks: https://css-tricks.com/snippets/css/a-guide-to-flexbox/
w3schools - https://www.w3schools.com/css/css3_flexbox.asp
Video series - https://www.youtube.com/watch?v=Y8zMYaD1bz0&list=PL4cUxeGkcC9i3FXJSUfmsNOx8E7u6UuhG
Grade: Meets Expectations
Summary: Overall, I think you did a good job with your implementation. The page design looked great excluding the heading image section, and the code was clean and easily readable.
There were several areas of improvement here. First, try to always stay consistent with how you format your code in any language. This is important because it makes the code look better while following best practices which in turn will make the code easier to understand and work with. Next, add descriptions for each important section of the page to improve the code readability. Finally, try to simplify the CSS code when there are shared properties for multiple elements to keep the code concise and remove repetition.
As a further challenge, consider adding responsive design to your page. This might take some extra research, but can be a great way to learn and apply important web design concepts. Based on your work so far, I think you are up for the challenge. Keep up the good work!