search

Lessig2016 / pledgeservice

GNU Affero General Public License v3.0
9 stars 8 forks source link

Only generate states totals every 10m #11

Closed abliss closed 9 years ago

abliss commented 9 years ago

Here's a quick and dirty patch to address the performance concern. It has the downside that it blocks the unlucky user who first requests expired data, but the upside that no work gets done if nobody wants the data.

abliss commented 9 years ago

Oh, now that I'm an admin on the test site, I think I could deploy this change there and test it. Let me know if you'd like me to do that.

aaronlifshin commented 9 years ago

go ahead

On Fri, Sep 4, 2015 at 10:37 AM, Adam Bliss notifications@github.com wrote:

Oh, now that I'm an admin on the test site, I think I could deploy this change there and test it. Let me know if you'd like me to do that.

— Reply to this email directly or view it on GitHub https://github.com/Lessig2016/pledgeservice/pull/11#issuecomment-137801642 .

abliss commented 9 years ago

OK, seems to work as intended. https://lessig-trust-test.appspot.com/r/states

aaronlifshin commented 9 years ago

Oh.. so, it occurs to me that Paypal donations are not eligible for matching funds... are we counting those?

aaronlifshin commented 9 years ago

Can you guys not count PayPal donations in this total? There is an FEC guidance from like 8 years ago on which contributions are eligible, and it kind of is ambiguous when it comes to PayPal.