search

Lessig2016 / pledgeservice

GNU Affero General Public License v3.0
9 stars 8 forks source link

New handler for exposing state-by-state donation totals. #4

Closed abliss closed 9 years ago

abliss commented 9 years ago

A response to https://mobile.twitter.com/lessig/status/638424623105896449?s=17

rickhanlonii commented 9 years ago

Great stuff.

aaronlifshin commented 9 years ago

Worried about performance of this. It needs to be a back end thread that updates totals every minute or so. Otherwise if we include it in a webpage it may be very slow.

A

On Wed, Sep 2, 2015 at 10:14 AM, Rick Hanlon II notifications@github.com wrote:

Great stuff.

— Reply to this email directly or view it on GitHub https://github.com/Lessig2016/pledgeservice/pull/4#issuecomment-137175505 .

abliss commented 9 years ago

Yeah, I agree it may be slow. I didn't do anything fancier because I'm having a hard time setting up a viable dev server to test on. I wrote it this simple way to have best hopes of it working correctly untested.

There's currently no web page pointing at the endpoint, so I was hoping I could cajole you into pushing it to production (or a test server with a static pledge dump), then we can test to see just how bad the performance is. On Sep 2, 2015 1:23 PM, "Aaron Lifshin" notifications@github.com wrote:

Worried about performance of this. It needs to be a back end thread that updates totals every minute or so. Otherwise if we include it in a webpage it may be very slow.

A

On Wed, Sep 2, 2015 at 10:14 AM, Rick Hanlon II notifications@github.com wrote:

Great stuff.

— Reply to this email directly or view it on GitHub < https://github.com/Lessig2016/pledgeservice/pull/4#issuecomment-137175505> .

— Reply to this email directly or view it on GitHub https://github.com/Lessig2016/pledgeservice/pull/4#issuecomment-137178181 .

aaronlifshin commented 9 years ago

@furf is going to pull this in and drop it into our test server

On Wed, Sep 2, 2015 at 10:28 AM, Adam Bliss notifications@github.com wrote:

Yeah, I agree it may be slow. I didn't do anything fancier because I'm having a hard time setting up a viable dev server to test on. I wrote it this simple way to have best hopes of it working correctly untested.

There's currently no web page pointing at the endpoint, so I was hoping I could cajole you into pushing it to production (or a test server with a static pledge dump), then we can test to see just how bad the performance is. On Sep 2, 2015 1:23 PM, "Aaron Lifshin" notifications@github.com wrote:

Worried about performance of this. It needs to be a back end thread that updates totals every minute or so. Otherwise if we include it in a webpage it may be very slow.

A

On Wed, Sep 2, 2015 at 10:14 AM, Rick Hanlon II < notifications@github.com> wrote:

Great stuff.

— Reply to this email directly or view it on GitHub <

https://github.com/Lessig2016/pledgeservice/pull/4#issuecomment-137175505>

.

— Reply to this email directly or view it on GitHub < https://github.com/Lessig2016/pledgeservice/pull/4#issuecomment-137178181> .

— Reply to this email directly or view it on GitHub https://github.com/Lessig2016/pledgeservice/pull/4#issuecomment-137179934 .

furf commented 9 years ago

Hey @abliss! Thanks for the help. Would you mind creating another pull request to the feature/state-by-state-totals branch so that I can run a quick perf check on test before integrating? (GitHub limitation)

abliss commented 9 years ago

Sure: https://github.com/Lessig2016/pledgeservice/pull/8