Can all functions access the context?

LesterLyu / fast-formula-parser

Parse and evaluate MS Excel formula in javascript.

MIT License

462 stars 64 forks source link

Closed rmdort closed 4 years ago

rmdort commented 4 years ago

2 issues

Functions supplied in functionsNeedContext does not work as it throws function not found error. This is because we are checking for custom functions in if (this.functions[name]) {
Right now only functionsNeedContext can access context position. Is there anyway we can inject context as the last argument to all functions ? Or the first arg ? Its quite useful when executing side-effects since we know the positions of the cell.

LesterLyu commented 4 years ago

Please provide the sample code where functionsNeedContext does not work.
- The test works: https://github.com/LesterLyu/fast-formula-parser/blob/master/test/grammar/test.js#L104
I cannot inject context to all functions, it will mess up internal functions.

rmdort commented 4 years ago

Ignore. My bad. Functions defined in functionsNeedContext works fine