Lesterhuis-Training-en-Consultancy / moodle-block-user_favorites

Moodle plugin - marking pages as favorites
GNU General Public License v3.0
1 stars 4 forks source link

Block drawer breaks in Moodle 4.1 #16

Closed stopfstedt closed 1 year ago

stopfstedt commented 1 year ago

Hey there, I was assessing this plugin for possible addition to our Moodle 4 instance this morning, and noticed that it breaks the block drawer after switching in and out of Edit Mode. This seems to be an intermittent failure - I wasn't able to trigger it reliably every time, but often enough to make it an issue.

The browser console shows the following error (or a variation thereof):

Uncaught Error: cannot call methods on tooltip prior to initialization; attempted to call method 'hide'

Once the error occurs, I'm unable to open (or close) the blocks drawer.

My stack:

image

the error seems to be linked to a JQuery-UI/Bootstrap-related interoperability issue, which has manifested itself in various places in Moodle before (see for example https://tracker.moodle.org/browse/MDL-74459)

gemguardian commented 1 year ago

@stopfstedt thank you for looking at this issue. I had the same experience, but we could not track the issue and thought it was related to a conflict of Plugins.

@luukverhoeven can you put this on your log to pull in when it's ready. Time is on my cost.

gemguardian commented 1 year ago

@stopfstedt I did not have the issue with Moodle 4.0 when I tested in last summer. But great if you want to check it again.

luukverhoeven commented 1 year ago

@gemguardian, would it be possible to include a section for acknowledging contributors in the readme or changelog? This would give credit to those who have made valuable contributions to the project.

gemguardian commented 1 year ago

@luukverhoeven yes please!

gemguardian commented 1 year ago
Comment from Freshservice:
Freshservice: 16728 linked successfully.