search

Lesterhuis-Training-en-Consultancy / moodle-block-user_favorites

Moodle plugin - marking pages as favorites
GNU General Public License v3.0
1 stars 4 forks source link

86bvz2mbb movingfavorites #23

Closed luukverhoeven closed 9 months ago

luukverhoeven commented 11 months ago

The context user class needed to be imported into the external service, that was actually the error when trying to change the order through an Ajax call.

luukverhoeven commented 11 months ago

@gemguardian Can you check if this update works? https://github.com/Lesterhuis-Training-en-Consultancy/moodle-block-user_favorites/tree/86bvz2mbb_movingfavorites

gemguardian commented 9 months ago

@luukverhoeven there is some 'strange' behavior when you change the name of the created link , sometimes it does work other times it does not - see the video: https://ltnc.screencasthost.com/watch/c0XrjQVGd03

I did not notice it in the other pull request

luukverhoeven commented 9 months ago

@gemguardian, the issue you've encountered should now be resolved. You can find the fix in this commit: https://github.com/Lesterhuis-Training-en-Consultancy/moodle-block-user_favorites/pull/23/files/aeaa64194526024e3cddd205994ac09ef57115de..aec7d6123880bafe8e1e26582f35990f17d3cadb.

This issue was present in all versions. When closing the dialog by pressing next to it and reopen for editing, it will use the old value.