Error: Class "external_api" not found in MOODLE_402

[ewallah]

Error: Class "external_api" not found

blocks/user_favorites/classes/external.php:48
lib/classes/component.php:144

The external_api was moved in MOODLE_402_STABLE

use core_external\external_api;
use core_external\external_function_parameters;
use core_external\external_single_structure;
use core_external\external_value;

or

use core_external\{external_api, external_function_parameters, external_single_structure, external_value};

fixes the error in MOODLE_402_STABLE and MOODLE_403_STABLE

[gemguardian]

@ewallah thank you for your feedback. @luukverhoeven could you please let me know the time you need to make a 42 compatable version.

[luukverhoeven]

@gemguardian We expect that we can fix and test this in 30 minutes.

[gemguardian]

@luukverhoeven aproved

[gemguardian]

@luukverhoeven kun je mij aangeven wanneer dit op de planning staat?

[luukverhoeven]

@gemguardian We kunnen dit uiterlijk volgende week opleveren. Ik hoop dat dit snel genoeg is.

[gemguardian]

@luukverhoeven super dan zorg ik dat iemand het kan controleren.

[gemguardian]

Comment from Freshservice:

Freshservice: 18918 linked successfully.

Freshservice: #18918

By: Gemma Lesterhuis <gemma@ltnc.nl>

[luukverhoeven]

@gemguardian https://github.com/Lesterhuis-Training-en-Consultancy/moodle-block-user_favorites/pull/25

[gemguardian]

@luukverhoeven ik heb gevraagd aan Ronny om het te controleren. We komen daar deze week op terug.

[gemguardian]

@luukverhoeven deze is akkoord, ik weet niet goed hoe ik dit moet oppakken zeker niet met https://github.com/Lesterhuis-Training-en-Consultancy/moodle-block-user_favorites/issues/26#issuecomment-1819776046

[luukverhoeven]

@gemguardian merged to the master branch.