search

Lesterpig / sockpress

A simple express.js and socket.io wrapper for nodejs
MIT License
28 stars 9 forks source link

Sockpress Route Class #13

Closed stevenkissack closed 8 years ago

stevenkissack commented 8 years ago

Okay so I have added a Route class (Not Router as we discussed) as I feel this better describes the differences between the express.Router and this single Route class. I also feel that this will then allow a Router class to be added in future if needed and that can use these Route classes with very minimal changes. (Express router works this way: https://github.com/expressjs/express/tree/master/lib/router)

Let me know if you want me to change anything.

Thanks

Lesterpig commented 8 years ago

Thank you very much for this amazing work :)

I'll review it as soon as possible, probably this week-end!

stevenkissack commented 8 years ago

No problem, thank you for the initial work that allowed us to implement sockets so easily!

Lesterpig commented 8 years ago

Merged in https://github.com/Lesterpig/sockpress/commit/c3f53acf3f6ff6c98b2e71ec47a574f21e6e5355

I fixed some missing semi-colon and updated the README, leaving the code intact. Thank you again, your work is released in sockpress@1.1.0 :grinning:

stevenkissack commented 8 years ago

Brilliant, thanks a lot.