Leszek-Sieminski / screamingFrogR

R integration with Screaming Frog CLI
Other
24 stars 3 forks source link

Wrong cd E:/Programy/Screaming Frog SEO Spider/ #1

Closed osinthill closed 5 years ago

osinthill commented 5 years ago

Hi Leszek, Thanks for the script ! When I try to run the crawl, the cd is going to a wrong directory :

instead of : cd "C:\Program Files (x86)\Screaming Frog SEO Spider"

How can I change that ?

Error in Rstudio is

C:\Users\ntl9M76\Documents>cd E:/Programy/Screaming Frog SEO Spider/
The system cannot find the drive specified.

Thanks, Nicolas

osinthill commented 5 years ago

Sorry, just found it in R/sfr_command !

Leszek-Sieminski commented 5 years ago

Hi, thanks for the issue!

You're right, I forgot to include the global enviroment variable. I will fix this.

osinthill commented 5 years ago

Great :) Thank you Leszek !

Leszek-Sieminski commented 5 years ago

Hi Nicolas! I've fixed this, the path is now received from enviromental variable properly :) Please reinstall the package with devtools::install_github("Leszek-Sieminski/screamingFrogR") to obtain the fixed version.

I'm closing this issue, let me know if if everything works on your computer and please reopen or create a new issue in case of any bugs.

Cheers!

osinthill commented 5 years ago

Everything works fine :) Thanks ! Nicolas