search

LetItPlay / CryptoWizards-SmartContract

https://wizards.one
MIT License
6 stars 3 forks source link

difference from textual battle rules #6

Open GassaFM opened 6 years ago

GassaFM commented 6 years ago

https://github.com/LetItPlay/CryptoWizards-SmartContract/blob/84e9a06e0dda446c6acea786df0bd219e1afdecc/pvp/pvp.cpp#L501-L504

Here, the actual attack and defense can be 0. But the DNA battles description said they are both at least 1. So, which one is the intended behavior, the code or the document?

GassaFM commented 6 years ago

For what it's worth, starting random range from 0 instead of 1 is similar to upping all stats (attack and defense) by 1. Effectively, this increases the randomness of the outcome a little bit.

qpIlIpp commented 6 years ago

we fixed it, = next_rand(round.max_attack) + 1