Closed GoogleCodeExporter closed 9 years ago
I can take this one.
Original comment by james.e....@gmail.com
on 8 Sep 2007 at 3:57
Thanks, assigning to you.
Original comment by gavinjo...@gmail.com
on 8 Sep 2007 at 4:10
I can't get my SVN client (TortoiseSVN) to commit. Is there any tricks to using
google code or do I need more permissions? I'm using my google_code username
and the
generated passcode, but I keep getting authorization failures. I'm also kinda
new
using SVN, only used it for downloading projects and making patch files haven't
ever
committed back before.
--patch comments---
Added code to support viewing user comments.
I needed to modify the CommentList and Comment web controls to display which
story
the user commented on. Otherwise, it would just be a list of comments without
knowing
which story.
Also, there's no host_id value in the comment table, so we might want to add
that in
there for faster querying. Otherwise, we'll need to do a join to story to get
the
host_id value. We could add a trigger that would auto populate comment.host_id
on
insert by doing a lookup on story_id, etc. If we added that trigger we wouldn't
need
to edit the submit comment UI page.
Original comment by james.e....@gmail.com
on 8 Sep 2007 at 6:48
Attachments:
Are you using the HTTPS url? You should see two svn urls on the following page:
http://code.google.com/p/dotnetkicks/source
If not, I may have added an incorrect username for you. Is you email
'james.e.welch
at gmail.com' ?
Original comment by gavinjo...@gmail.com
on 8 Sep 2007 at 7:02
Please do add a host_id column to the comments table. I'll run a maintenance
script
to update existing comments when I deploy.
I would prefer to specifically supply the host_id on comment creation rather
than
using a trigger. The HostProfile is available in the KickPage base class.
Original comment by gavinjo...@gmail.com
on 8 Sep 2007 at 7:07
It was the HTTPS issue. I committed my changes. I will add the host_id code and
column later today.
Original comment by james.e....@gmail.com
on 8 Sep 2007 at 7:47
Great. I have deployed the latest to production. You can see the comments view
in action:
http://dotnetkicks.com/users/gavinjoyce/profile
Note that the sort order is currently not right and that the paging does not
seem to
be working. Other than those small issues it is looking great.
How would you feel about creating a new server control for the individual
comments in
this view? The title of the post should be prominent and it could link to the
actual
comment itself - something like:
http://dotnetkicks.com/community/Who_Kicked_It#Comment_2168
we could probably loose the published on and submitted by line.
What do you think?
Original comment by gavinjo...@gmail.com
on 8 Sep 2007 at 9:48
Actually, we could probably just modify the comment view control - it could
optionally display the title of the post with the link to the comment.
Original comment by gavinjo...@gmail.com
on 8 Sep 2007 at 9:49
Fixed the pagination problem. Created a SP to handle it so its like the others.
I had
to change some of the previous code to use the new SP of
Kick_GetPagedCommentsByUserIDAndHostID.
This fix requires that the kick_comment table have a field named HostID.
Also changed the story link to the local URL # comment id. Which meant I needed
to
update the Comment List to include the named anchor tag.
Here's the SP. code updates to come soon.
Original comment by james.e....@gmail.com
on 8 Sep 2007 at 11:02
Attachments:
I have committed the required sql scripts to the mainline. They can be found in:
\trunk\DotNetKicks\Database\
Original comment by gavinjo...@gmail.com
on 9 Sep 2007 at 8:14
I've just deployed these changes to DotNetKicks.com - it works great. Thanks for
contributing this feature.
Original comment by gavinjo...@gmail.com
on 9 Sep 2007 at 8:37
Original comment by james.e....@gmail.com
on 12 Sep 2007 at 4:27
Original issue reported on code.google.com by
gavinjo...@gmail.com
on 8 Sep 2007 at 11:27