search

Letractively / dotnetkicks

Automatically exported from code.google.com/p/dotnetkicks
1 stars 0 forks source link

Kicked by Friends very slow if you have no friends #91

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Steps to Reproduce

1. I have no friends :(
2. I go to profile and click Kicked by Friends
3. Browser hangs for about 30 seconds then the Oops error page is displayed.

Better check the query ;)

Submitted by Friends works fine saying there are no submissions.

Original issue reported on code.google.com by rpro...@gmail.com on 14 Sep 2007 at 5:48

GoogleCodeExporter commented 9 years ago 
Thanks, there is a bug here. It should be fixed this weekend.

Original comment by gavinjo...@gmail.com on 14 Sep 2007 at 5:51

GoogleCodeExporter commented 9 years ago 
I was just thinking about this. 

I think it will be good to debug the sp, but in the mean time, we can just do a 
check
on the profile's friends count. If friend count == 0, then don't set the 
datasource
of the storylist.

Original comment by james.e....@gmail.com on 14 Sep 2007 at 7:21

GoogleCodeExporter commented 9 years ago 
fixed in r317

by adding a check for this.UserProfile.Friends.Count.Equals(0)

I'll investigate into the SP after the dataset is prepared. Otherwise, this 
prevents
the timeouts for now.

Original comment by james.e....@gmail.com on 14 Sep 2007 at 8:51

GoogleCodeExporter commented 9 years ago 
Great timing, I'm just about to deploy the latest changes to DNK.com. If you 
have 5
mins to spare now, can you help me test out a new feature?

Original comment by gavinjo...@gmail.com on 14 Sep 2007 at 8:56

GoogleCodeExporter commented 9 years ago 
Yep. Send me an email and let me know what to test.

I also updated StoryList to make sure it is databound before trying to iterate
through the collection. We might want to look at the other list controls to 
check for
this also. 

added "if (_stories == null) return;" in rendering

Original comment by james.e....@gmail.com on 14 Sep 2007 at 9:00

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Works for me.

I guess I'd better find some friends now ;)

Original comment by rpro...@gmail.com on 14 Sep 2007 at 9:02

GoogleCodeExporter commented 9 years ago 
Goto http://www.dotnetkicks.com/whoisonline

There is the beginnings of a ShoutBox

Original comment by gavinjo...@gmail.com on 14 Sep 2007 at 9:05

GoogleCodeExporter commented 9 years ago 
I'll keep this bug open until we can resolve the problem with the SP, but 
downgrade
it to priority-low since we have a workaround for it implemented.

Original comment by james.e....@gmail.com on 14 Sep 2007 at 10:02

GoogleCodeExporter commented 9 years ago 
Need to find a user with friends, but where none of their friends have 
submitted or
kicked stories. That's another test case that I thought of a few hours ago. 

The workaround won't work for that scenario, because the logic just checks for
existence of friends.

Original comment by james.e....@gmail.com on 15 Sep 2007 at 7:37

GoogleCodeExporter commented 9 years ago

Original comment by james.e....@gmail.com on 15 Sep 2007 at 11:47

GoogleCodeExporter commented 9 years ago 
I want to make friend ship to get & given solve the quaries.

Original comment by virupaji...@gmail.com on 16 Jul 2008 at 6:36