search

Letractively / fuuka

Automatically exported from code.google.com/p/fuuka
Other
0 stars 0 forks source link

Quote preview (+patch) #72

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Not sure how badly it overlaps with any existing userscripts, but still.

Here is a minimal quote preview implementation.
Seems to work fine in every major browser (I left out IE7 because of 
querySelectorAll)

Cheers.

Original issue reported on code.google.com by desuw...@gmail.com on 1 Jan 2012 at 7:33

Attachments:

GoogleCodeExporter commented 8 years ago 
> function who_are_you_quoting
Brilliant.

Give me a while to check it out and I'll commit this, most likely.

Original comment by eksopl on 17 Jan 2012 at 12:43

GoogleCodeExporter commented 8 years ago 
Just noticed that things get weird when the quote link appears in the middle of 
a line (post 8355911 on /jp/ for example).

This should fix it:

board.js
70: e.parentNode.insertBefore(cnt, e.nextSibling);
77: (e.target || window.event.srcElement).parentNode.removeChild(cnt);

fuuka.css
139: #q-p {
140:   position: absolute;
141:   color: #002200;
142: }

Original comment by desuw...@gmail.com on 17 Jan 2012 at 9:47

GoogleCodeExporter commented 8 years ago 
Very nice, thank you!

I changed your patch a little because that data-backlink attribute isn't valid 
XHTML 1.0 Strict, which Fuuka prides itself to be. On another hand, that 
allowed me to replace querySelectorAll, so perhaps this will also work in IE7? 
I don't have any IE readily available to test.

It would be extra nice if posts had the forwardlinks of the replies that are 
quoting them, though. So I'll leave this issue open for that.

Original comment by eksopl on 31 Jan 2012 at 1:26

GoogleCodeExporter commented 8 years ago 
It seems theres a glitch with the most recent (since this post) Firefox Nightly 
build.

The overlay panel doesn't ever disappear, I've tried to click away from it but 
it seems to stay anyway.

Original comment by aa...@installgentoo.net on 1 Feb 2012 at 1:43

GoogleCodeExporter commented 8 years ago 
>remove_quote_preview is not defined

Are you sure you merged the files properly?

Original comment by max...@gmail.com on 1 Feb 2012 at 1:57

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
Yeah it seems I merged the files wrong.

Original comment by aa...@installgentoo.net on 1 Feb 2012 at 2:15

GoogleCodeExporter commented 8 years ago 
 It would be extra nice if posts had the forwardlinks of the replies that are quoting them, though.

You want to integrate it directly into fuuka, or as a userscript maybe?

Original comment by desuw...@gmail.com on 2 Feb 2012 at 2:39

GoogleCodeExporter commented 8 years ago 
Into Fuuka itself. I'm fond of the way Foolz does it, with that small "Quoted 
by:" text, like this:
http://archive.foolz.us/jp/thread/8502384/#8508105

I'll just make it a config option to have backlinks/forwardlinks disabled or 
enabled, so the site admin can easily choose.

Original comment by eksopl on 2 Feb 2012 at 7:18

GoogleCodeExporter commented 8 years ago

Original comment by eksopl on 19 Feb 2012 at 1:44

GoogleCodeExporter commented 8 years ago 
Moved these issues to Github ( https://github.com/eksopl/fuuka/issues ). I just 
can't stand Google Code's issue tracking stuff anymore. I deeply apologize. Its 
lack of editing comments, comment previewing and any kind of comment markup is 
driving me insane.

fuuka @ Google Code still remains the official repo, though.

Original comment by eksopl on 20 Feb 2012 at 1:50