search

Letractively / golismero

Automatically exported from code.google.com/p/golismero
0 stars 0 forks source link

md5 module is deprecated #1

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
./golismero/libs/updater.py:5: DeprecationWarning: the md5 module is 
deprecated; use hashlib instead
  import md5

Original issue reported on code.google.com by he...@nerv.fi on 14 Nov 2011 at 7:20

GoogleCodeExporter commented 8 years ago 
I can create a patch for you if needed.

http://docs.python.org/library/md5.html
http://docs.python.org/library/hashlib.html

Original comment by he...@nerv.fi on 14 Nov 2011 at 7:27

GoogleCodeExporter commented 8 years ago 
Very thanks for your report. If you can fix it would be great.

Regards!

Original comment by garcia.g...@gmail.com on 14 Nov 2011 at 5:26

GoogleCodeExporter commented 8 years ago 
It would be much easier to contribute if code was commented in english. Could 
you translate those?

There is also other bugs in the update-mechanism, which probably are minor 
issues like no IOError checks in some file-system activities and such.

Original comment by he...@nerv.fi on 14 Nov 2011 at 8:22

GoogleCodeExporter commented 8 years ago 
Sorry for the inconvenience. The code is not commented in english because when 
I wrote initially I don't think to publish it. I hope to translate the comments 
as soon as posible. I'll start translating the comments for "updater.py"

Sure there are many errors. I appreciate any help.

Original comment by garcia.g...@gmail.com on 16 Nov 2011 at 4:20

GoogleCodeExporter commented 8 years ago 
I just update comments to updater.py, you can download from: 

http://golismero.googlecode.com/git/libs/updater.py

English translated comments are a "T: ". Sorry for my bad english :)

Regards and thank you!

Original comment by garcia.g...@gmail.com on 16 Nov 2011 at 7:38

GoogleCodeExporter commented 8 years ago 
Just wondering is there was a patch available for the "DeprecationWarning: the 
md5 module is deprecated"?

Original comment by stephan....@gmail.com on 10 Jan 2012 at 2:47

GoogleCodeExporter commented 8 years ago 
Very easily after you commit the updater.py patch as these lines are remaining:

Admin/ChangesGenerator.py:import md5
Admin/ChangesGenerator.py:  m_md5 = md5.new()
Admin/ChangesGenerator.py:      m_md5.update(filename)
Admin/ChangesGenerator.py:      firma = m_md5.hexdigest()

Original comment by he...@nerv.fi on 10 Jan 2012 at 4:04

GoogleCodeExporter commented 8 years ago 
Sorry, by you I meant garcia.garcia.daniel :)

Original comment by he...@nerv.fi on 10 Jan 2012 at 4:08

GoogleCodeExporter commented 8 years ago

Original comment by he...@nerv.fi on 10 Jan 2012 at 4:09

GoogleCodeExporter commented 8 years ago 
We hope that this issue will be fixed in next version. Meanwhile henri was 
commit a patch.

Regards!

Original comment by garcia.g...@gmail.com on 10 Jan 2012 at 4:25

GoogleCodeExporter commented 8 years ago 
"Was commit a patch." what do you mean? :)

Original comment by he...@nerv.fi on 10 Jan 2012 at 4:37

GoogleCodeExporter commented 8 years ago 
All "import md5" -lines replaced with new code.

Original comment by he...@nerv.fi on 15 Jan 2012 at 12:58