Letractively / jcatapult

Automatically exported from code.google.com/p/jcatapult
0 stars 0 forks source link

The form control fails if the action attribute isn't specified #110

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
The form control is overriding renderStart and pre-processing the action 
attribute. However, it 
doesn't validate the attributes prior to this (since that happens in the 
AbstractControl's renderStart 
method) and if the action attribute is missing, a NPE is thrown.

To fix this, I'd either wrap the logic in an if-check against that attribute or 
call verifyAttributes in 
the renderStart. The latter will end up verifying the attributes twice, so a 
flag might be required for 
performance.

Original issue reported on code.google.com by bpontare...@gmail.com on 14 Apr 2009 at 3:30