search

Letractively / jcatapult

Automatically exported from code.google.com/p/jcatapult
0 stars 0 forks source link

Corrupt images upon project creation #41

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Reproduce by doing the following:
1. Modify the default project template to contain a bunch of images
(or, presumably other binary files)
2. Create a project using the ANT create-project target (in jcatapult-ant)
3. View the images which are in the newly created project. The images will
be corrupted/garbled in the newly created project.

I'm using JCatapult-1.0RC1 on Windows XP.

Please provide any additional information below.
The issue is caused because the ANT create-project target does a
find/replace (using an ANT filter) on almost all files when copying files
from the template project to the new project's location. Filtering is not
safe on binary files. See http://ant.apache.org/manual/using.html#filters. 

James and I tried forcing the ISO-8859-1 encoding and it helped, but there
were still hosed images. So, I split the first copy task into two parts: 1)
Copy/filter all files of certain file extensions and 2) Copy the rest of
the files, without filtering.

See attached patch for my suggested fix. I added a bunch o' comments. 

Beware: I am using a modified version of the create-project target so
you'll want to scrutinize my patch file cause I haven't tested it in
jcatapult-ant. Also, the patch should create another file
(filtering-includes.txt) in the makeproject directory.

Original issue reported on code.google.com by rtgam...@gmail.com on 15 May 2008 at 11:04

Attachments:

GoogleCodeExporter commented 8 years ago 
Thanks for the submission Todd.  We'll get it into the codebase for 1.0-RC2.

Original comment by leafkn...@gmail.com on 15 May 2008 at 11:12

GoogleCodeExporter commented 8 years ago 
Todd, if possible, can you patch these changes into the
jcatapult-ant/tools/makeproject/build.xml file and resubmit the patch?

Thanks,

jH.

Original comment by leafkn...@gmail.com on 7 Jul 2008 at 10:31

GoogleCodeExporter commented 8 years ago

Original comment by bpontare...@gmail.com on 25 Jul 2008 at 2:05

GoogleCodeExporter commented 8 years ago

Original comment by leafkn...@gmail.com on 10 Sep 2008 at 8:10

GoogleCodeExporter commented 8 years ago 
I'm going to close this for now. The current templates have no images and custom
templates can handle this case themselves.

Original comment by bpontare...@gmail.com on 14 Sep 2008 at 10:04

GoogleCodeExporter commented 8 years ago

Original comment by bpontare...@gmail.com on 14 Sep 2008 at 10:04